On Tue 02-09-14 18:46:39, Ted Tso wrote: > The __jbd2_journal_remove_checkpoint() doesn't require an elevated > b_count; indeed, until the jh structure gets released by the call to > jbd2_journal_put_journal_head(), the bh's b_count is elevated by > virtue of the existence of the jh structure. > > Suggested-by: Jan Kara <jack@xxxxxxx> > Signed-off-by: Theodore Ts'o <tytso@xxxxxxx> Looks good so you can add: Reviewed-by: Jan Kara <jack@xxxxxxx> Just we can do a bit more as I mentioned in my other email: > @@ -359,8 +354,9 @@ restart2: > * know that it has been written out and so we can > * drop it from the list > */ > - done = __jbd2_journal_remove_checkpoint(jh); > __brelse(bh); Here we don't need to grab bh reference unless we are going to call wait_on_buffer(). Which moves get_bh / __brelse out of fast path. > + if (__jbd2_journal_remove_checkpoint(jh)) > + break; > } > out: > spin_unlock(&journal->j_list_lock); Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
