On Tue, Feb 22, 2011 at 09:32:28AM -0700, Andreas Dilger wrote: > Roger, > Any idea what the hash size does to memory usage? I wonder if we > can scale this based on the directory count, or if the memory usage > is minimal (only needed in case of tdb) then just make it the > default. It definitely appears to have been a major performance > boost. First, that hash size is passed to the tdb module, so yes it only matters when tdb is actually used. Second, I expect tdb's memory use to be significantly impacted by the hash size. However.... tdb's memory use is dwarfed by e2fsck's own memory use.... I have not noticed any difference in memory use of e2fsck. (by watching "top" output. I haven't done any scientific measurements.) > Another possible optuzatiom is to use the in-memory icount list > (preferably with the patch to reduce realloc size) until the > allocations fail and only then dump the list into tdb? That would > allow people to run with a swapfile configured by default, but only > pay the cost of on-disk operations if really needed. I don't think this is a good idea. When you expect the "big" allocations to eventually fail (i.e. icount), you'll evenutally end up with an allocation somewhere else that fails where you don't have anything prepared for. A program like e2fsck will be handling larger and different filesystems "in the field" from what you expected at the outset. It should be robust. My fsck is currently walking the ridge.... It grew from about 1000M to over 2500 after pass 1. I was expecting it to hit the 3G limit before the end. But luckily somehow some memory got released, and now it seems stable at 2001Mb. It is currently again in a CPU-bound task. I think it's doing lots of tdb lookups. It has asked me: First entry 'DSCN11194.JPG' (inode=279188586) in directory inode 277579348 (...) should be '.' Fix<y>? yes Which is clearly wrong. IF we can find directory entries in that directory (i.e. it acutally IS a directory), then it is likely that the file DSCN11194.JPG still exists, and that it has inode 279188586. If it should've been '.', it would've been inode 277579348. So instead of overwriting this "first entry" of the directory, the fix should've been: Directory "." is missing in directory inode 277579348. Add? If neccesary, place should be made inside the directory. Roger. -- ** R.E.Wolff@xxxxxxxxxxxx ** http://www.BitWizard.nl/ ** +31-15-2600998 ** ** Delftechpark 26 2628 XH Delft, The Netherlands. KVK: 27239233 ** *-- BitWizard writes Linux device drivers for any device you may have! --* Q: It doesn't work. A: Look buddy, doesn't work is an ambiguous statement. Does it sit on the couch all day? Is it unemployed? Please be specific! Define 'it' and what it isn't doing. --------- Adapted from lxrbot FAQ -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
