Dan Carpenter wrote: > Smatch (http://repo.or.cz/w/smatch.git/) complains about the locking in > ext4_mb_add_n_trim() from fs/ext4/mballoc.c > > I think it's meant to be spin_unlock(&tmp_pa->pa_lock); on line 4442. > > 4438 list_for_each_entry_rcu(tmp_pa, &lg->lg_prealloc_list[order], > 4439 pa_inode_list) { > 4440 spin_lock(&tmp_pa->pa_lock); > 4441 if (tmp_pa->pa_deleted) { > 4442 spin_unlock(&pa->pa_lock); > 4443 continue; > 4444 } > > I can send a patch if I'm right or you could just give me a: > Reported-by: Dan Carpenter <error27@xxxxxxxxx> Seems right to me, Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx> although I wonder why we don't trip over this in spinlock debugging (seems like it'd lead to a double unlock at times) I wonder if we can tie this to any other bugs we've seen. Thanks, -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
