On Fri, Mar 27, 2009 at 01:27:04PM +0300, Dan Carpenter wrote: > Smatch (http://repo.or.cz/w/smatch.git/) complains about the locking in > ext4_mb_add_n_trim() from fs/ext4/mballoc.c > > I think it's meant to be spin_unlock(&tmp_pa->pa_lock); on line 4442. > > 4438 list_for_each_entry_rcu(tmp_pa, &lg->lg_prealloc_list[order], > 4439 pa_inode_list) { > 4440 spin_lock(&tmp_pa->pa_lock); > 4441 if (tmp_pa->pa_deleted) { > 4442 spin_unlock(&pa->pa_lock); > 4443 continue; > 4444 } > > I can send a patch if I'm right or you could just give me a: > Reported-by: Dan Carpenter <error27@xxxxxxxxx> > Good catch. Can you send a proper patch with signed-off-by. You can add Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxx> -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
