Re: [patch] ext4: typo leads to small leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dan Carpenter wrote:
> This was found by smatch (http://repo.or.cz/w/smatch.git/)
> 
> regards,
> dan carpenter
> 
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Thanks!  Maybe one for the stable trees.

> --- orig/fs/ext4/mballoc.c	2009-03-26 18:22:30.000000000 +0300
> +++ devel/fs/ext4/mballoc.c	2009-03-26 18:22:56.000000000 +0300
> @@ -2693,7 +2693,7 @@
>  	i = (sb->s_blocksize_bits + 2) * sizeof(unsigned int);
>  	sbi->s_mb_maxs = kmalloc(i, GFP_KERNEL);
>  	if (sbi->s_mb_maxs == NULL) {
> -		kfree(sbi->s_mb_maxs);
> +		kfree(sbi->s_mb_offsets);
>  		return -ENOMEM;
>  	}
>  
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux