On Thu, Jul 31, 2008 at 03:00:32PM +0900, Hidehiro Kawai wrote: > I tested this patch on 2.6.27-rc1, but it didn't work properly. > Then, I noticed two mistakes. > > (1) journal_submit_data_buffers() just submits I/Os, doesn't wait > their completion. We have to check file data write errors > after calling journal_finish_inode_data_buffers() > (2) AS_EIO is cleared by wait_on_page_writeback_range(), so we > have to set it again Thank you very much for catching these errors; you are very correct! > I attached the revised patch below. journal_submit_data_buffers() > can return error, but it wouldn't be write I/O error AFAIK, so I > didn't touched. I've replaced the patch with your revised patch in the ext4 patch queue; thanks again for double-checking the patch and offering the revised version. Many thanks, - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
