On Jul 31, 2008 23:03 +0530, Aneesh Kumar wrote: > With the below changes we reserve credit needed to insert only one extent > resulting from a call to single get_block. That make sure we don't take > too much journal credits during writeout. We also don't limit the pages > to write. That means we loop through the dirty pages building largest > possible contiguous block request. Then we issue a single get_block request. > We may get less block that we requested. If so we would end up not mapping > some of the buffer_heads. That means those buffer_heads are still marked delay. > Later in the writepage callback via __mpage_writepage we redirty those pages. Can you please clarify this? Does this mean we take one pass through the dirty pages, but possibly do not allocate some subset of the pages. Then, at some later time these holes are written out separately? This seems like it would produce fragmentation if we do not work to ensure the pages are allocated in sequence. Maybe I'm misunderstanding your comment and the unmapped pages are immediately mapped on the next loop? It is great that this will potentially allocate huge amounts of space (up to 128MB ideally) in a single call if the pages are contiguous. The only danger I can see of having many smaller transactions instead of a single larger one is if this is causing many more transactions in the case of e.g. O_SYNC or similar, but AFAIK that is handled at a higher level and we should be OK. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
