On 2022-08-25 11:36, Ido Schimmel wrote:
On Tue, Aug 23, 2022 at 01:41:51PM +0200, netdev@xxxxxxxxxxxxxxxxxxxx
wrote:
On 2022-08-23 08:48, Ido Schimmel wrote:
>
> I'm not good at naming, but "blackhole" is at least consistent with what
> we already have for routes and nexthop objects.
>
I have changed it the name "masked", as that is also the term used in
the
documentation for the zero-DPV entries, and I think that it will
generally
be a more accepted term.
"blackhole" is an already accepted term and at least to me it is much
more clear than "masked". Keep in mind that both L2 neighbours (FDB)
and
L3 neighbours share the same uAPI and eventually we might want to
extend
the use of this flag for L3 neighbours (at least Spectrum supports it),
so it needs to make sense for both.
I have changed the name of the flag to 'blackhole', but the struct entry
in switchdev_notifier_fdb_info and a function input parameter is still
named 'masked'. If that should be changed before I send out V5, please
let me know as I hope to get this patch set accepted.
