On 2022-08-25 13:58, Ido Schimmel wrote:
On Thu, Aug 25, 2022 at 12:27:01PM +0200, netdev@xxxxxxxxxxxxxxxxxxxx
wrote:
Instead of skipping it you can check that roaming fails when "sticky"
is
set.
I think that the sticky flag topic generally is beyond the MAB feature,
and it doesn't really fit into the bridge_locked_port.sh.
But anyhow I guess I can add it to the bridge_sticky_fdb.sh tests.
The bridge_locked_port.sh test is linked in
tools/testing/selftests/drivers/net/dsa/, but if I cannot check if the
mv88e6xxx driver or other switchcores are in use, I cannot do more.
Since the behavior of the HW data path is reflected to the software
bridge and user space via "sticky" / "blackhole" / "extern_learn", you
should be able to add test cases to the generic selftest. For example,
if "blackhole" is set, then simple ping is expected to fail. Otherwise
it is expected to pass.
The problem here is that the "blackhole" flag can only be set now from
the mv88e6xxx driver under a locked port, and the locked port itself
will not allow ping to work anyhow without a FDB entry free of the
"locked" flag, as the MAB tests verify.
And disabling MAB on the locked port on the mv88e6xxx will clean the
locked entries.
So I see it as a flag for future use, otherwise I will have to add a
userspace command to enable the "blackhole" flag.
I have now made station move tests for both the locked port and MAB
cases.
