> From: linux-efi-owner@xxxxxxxxxxxxxxx [mailto:linux-efi-owner@xxxxxxxxxxxxxxx] On Behalf Of Kees Cook > >>> > + rec->timestamp = get_seconds(); >> >>> timestamp will already be correctly populated by the pstore API, so it should be copied from there rather than using get_seconds() which may not be functional during resume, etc. >> >> Looks like that the timestamp member "time" of struct pstore_record passed from pstore "fs/pstore/platform.c" -> pstore_dump() is not set for DMESG case. > >The change for the timestamp has been in the -next tree ("pstore: >Populate pstore record->time field"). If that doesn't work how you want it, please let me know and I can adjust it. OK, will copy the timestamp value (rather than using get_seconds) passed from pstore API in v4. Thanks! BR qiuxu ��.n��������+%������w��{.n�����{����*jg��������ݢj����G�������j:+v���w�m������w�������h�����٥