On Wed, Jun 21, 2017 at 1:45 AM, Zhuo, Qiuxu <qiuxu.zhuo@xxxxxxxxx> wrote: >> From: keescook@xxxxxxxxxx [mailto:keescook@xxxxxxxxxx] On Behalf Of Kees Cook >> Sent: Wednesday, June 21, 2017 7:27 AM >> >> > + >> > +static bool efi_capsule_pstore_disable = >> > + IS_ENABLED(CONFIG_CAPSULE_PSTORE_DEFAULT_DISABLE); >> >> This can be marked __ro_after_init. > > OK. Will mark it __ro_after_init in next version. > >> > + >> > + rec->type = record->type; >> > + rec->timestamp = get_seconds(); >> >> timestamp will already be correctly populated by the pstore API, so it should be copied from there rather than using get_seconds() which may not be functional during resume, etc. > > Looks like that the timestamp member "time" of struct pstore_record passed from pstore "fs/pstore/platform.c" -> pstore_dump() is not set for DMESG case. The change for the timestamp has been in the -next tree ("pstore: Populate pstore record->time field"). If that doesn't work how you want it, please let me know and I can adjust it. -Kees -- Kees Cook Pixel Security -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
