> > > How about do not limit to only if (pgd) case, instead do something > > like below: set dump_to_dmesg as a module parameter > > X86_PTDUMP is not a module. Hmm, I just see the module macros in the code, since it's a bool Kconfig I think the dump_pagetables.c need a cleanup, remove the #include <linux/module.h> and below lines: MODULE_LICENSE("GPL"); MODULE_AUTHOR("Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>"); MODULE_DESCRIPTION("Kernel debugging helper that dumps pagetables"); > > And even though the idea to make the efi pagetable dumpable with a > kernel cmdline parameter doesn't sound all that bad, I'd like to hold > off on adding yet another efi= cmdline option and only do so until it is > really needed. I think not necessary limit to efi=? Probably something like ptdump_dmesg=1|0 Thanks Dave -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html