> -----Original Message----- > From: Matt Fleming [mailto:matt@xxxxxxxxxxxxxxxxx] > Sent: Wednesday, November 27, 2013 6:45 AM > To: Madper Xie > Cc: 'linux-kernel@xxxxxxxxxxxxxxx'; linux-efi@xxxxxxxxxxxxxxx; matt.fleming@xxxxxxxxx; Seiji Aguchi; richard@xxxxxx; Tony Luck > Subject: Re: [PATCH v2] efi-pstore: Make efi-pstore return a unique id > > On Sat, 23 Nov, at 07:55:37PM, Madper Xie wrote: > > > > Pstore fs expects that backends provide a uniqued id which could avoid > > pstore making entries as duplication or denominating entries the same > > name. So I combine the timestamp, part and count into id. > > > > Signed-off-by: Madper Xie <cxie@xxxxxxxxxx> > > --- > > drivers/firmware/efi/efi-pstore.c | 19 +++++++++++++------ > > 1 file changed, 13 insertions(+), 6 deletions(-) > > Thanks unless anyone complains, I'm going to apply this. > I'm OK with this patch based on Madper's comment below. <snip> So i'd like to using fixed length. My dell xps has 128kb nvram space. and it at most store 126 pstore entries. So I think 1000 will be a safe value for count. For part, 100 should be okay. I don't think there will be a large kmsg and we must split it into more than 100 parts. <snip> > Does this need to be tagged for stable? > I think so. Seiji > -- > Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
