> > +
> > + if (efi.config_table != EFI_INVALID_TABLE_ADDR) {
> > + error = sysfs_create_file(efi_kobj,
> > + &efi_attr_config_table.attr);
> > + if (error) {
> > + pr_err("efi: Sysfs attribute %s export failed with error %d.\n",
> > + efi_attr_config_table.attr.name, error);
> > + goto err_remove_runtime;
> > + }
> > + }
>
> You don't need to do this "if SOMETHING then create the file", just use
> the "is_visible" attribute in the group to do this as a callback to
> determine this when the group is registered.
I did not know the is_visible before, thanks for the hint, will use it
--
Thanks for review
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
