On Sat, Aug 31, 2013 at 12:12 AM, Roy Franz <roy.franz@xxxxxxxxxx> wrote: > On Fri, Aug 30, 2013 at 6:39 AM, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote: >> I think you need some description in the commit text about why the type >> of chunksize is changing. It's not clear why you're making this change. >> It is a bug fix? > > The type was changed to match the EFI_FILE_PROTOCOL specification - > chunk size is > defined as a native width unsigned integer. So yes, this is a bug in > that this is wrong for > ia32, since that really should be a u32 in that case. > Since the x86 wrappers break type checking by the compiler these types > were never checked at compile time > before. chunksize is the the only change that isn't a cast to a type > of void pointer. > > I can break this change out as a separate patch if desired. I don't think it needs to be in a separate patch, but it does need to be described in the patch description. g. -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
