On Mon, Aug 12, 2013 at 7:51 AM, Mark Salter <msalter@xxxxxxxxxx> wrote: > On Fri, 2013-08-09 at 16:26 -0700, Roy Franz wrote: >> +static int relocate_kernel(efi_system_table_t *sys_table, >> + unsigned long *zimage_addr, >> + unsigned long zimage_size, >> + unsigned long min_addr, unsigned long max_addr) >> +{ >> + /* Get current address of kernel. */ >> + unsigned long cur_zimage_addr = *zimage_addr; >> + unsigned long new_addr = 0; >> + >> + efi_status_t status; >> + >> + if (!zimage_addr || !zimage_size) >> + return EFI_INVALID_PARAMETER; >> + > > This parameter check is too late. You already used zimage_addr to > initialize cur_zimage_addr. > > --Mark > Thanks - I'll fix this in the next version. Roy -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html