> the problem isn't anything to > do with memset, it's because we're not getting a new allocation each > time we call efivar_create_sysfs_entries(). I see. I agree with you. I will update my patch with your explanation below. Seiji > > --- > Subject: [PATCH] efivar: fix oops in efivar_update_sysfs_entries() caused by memory reuse > > The loop in efivar_update_sysfs_entries() reuses the same allocation for > entries each time it calls efivar_create_sysfs_entry(entry). This is > wrong because efivar_create_sysfs_entry() expects to keep the memory it > was passed, so the caller may not free it (and may not pass the same > memory in multiple times). This leads to the oops below. Fix by > getting a new allocation each time we go around the loop. > > [insert oops report here] > --- > > James > -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
