On 26/03/13 23:33, Seiji Aguchi wrote: > If we can calculate the size of available variables by ourselves, > we don't need to call QueryVariableInfo(). > It makes efivars robust against buggy firmwares. > Also, this patch actually fixes a serious bug, failing boot up. > > In theory, QueryVariableInfo() should return accurate values to kernel. > But, it doesn't in practice. Exactly and this patch is *still* relying on the output of QueryVariableInfo(). I doubt DataSize will be accurate everywhere either. > I think creating blacklist will be like playing whac-a-mole, because > we can't anticipate how many buggy firmwares will appear in the future. You wouldn't need to reimplement the workaround for every broken machine, you just add the machine's identifiers to the list. And no, we can't anticipate the firmware bugs we'll see in the future which is why we need to solve this on a case-by-case basis. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
