> > By the way, efivar_update_sysfs_entries from Seiji's sysfs workqueue > > patch may also get stuck in loop in the same way. In my understanding, a problem reported initially is that WARN_ON() in create_sysfs_entries() hits because multiple sysfs entries of a same variable name are created. On the other hand, in efivar_update_sysfs_entries(), the WARN_ON never hits because If a variable is already present, create_sysfs_entries() is never called. > > You mean if GetNextVariableName() never terminates? Yeah, > efivar_update_sysfs_entries() looks like it needs protecting from that too, good catch. If there is a case where GetNextVariableName() never terminates, I agree that efivar_update_sysfs_entries() should be protected from that . But I'm not sure if the case is related to a bug in this thread.. Seiji ��.n��������+%������w��{.n�����{����*jg��������ݢj����G�������j:+v���w�m������w�������h�����٥