Hi Matt,
On 2013-03-06 08:19, Matt Fleming wrote:
On Tue, 2013-03-05 at 17:39 +0800, Lingzhu Xiang wrote:
On 03/03/2013 02:03 AM, Andre Heider wrote:
> After a BIOS update I get this in dmesg:
>
> [ 0.581554] EFI Variables Facility v0.08 2004-May-17
> [ 0.584914] ------------[ cut here ]------------
> [ 0.585639] WARNING: at /home/andre/linux/fs/sysfs/dir.c:536
sysfs_add_one+0x
> d4/0x100()
> [ 0.586381] Hardware name: To be filled by O.E.M.
> [ 0.587123] sysfs: cannot create duplicate filename
'/firmware/efi/vars/SbAsl
> BufferPtrVar-01f33c25-764d-43ea-aeea-6b5a41f3f3e8'
> (snip)
>
> Sounds like yet another BIOS issue, and I guess the answer is
> "complain to the manufacturer"... But we know how well that works,
so
> can this be a warning instead of a scary backtrace? :)
>
> (this is: Gigabyte Technology Co., Ltd. To be filled by
> O.E.M./Z77X-UD3H, BIOS F19e 11/21/2012)"
Just saw https://bugzilla.kernel.org/show_bug.cgi?id=47631
I think this problem is getting more and more common.
I had an IBM System x3100 M4 and x3850 X5 on which kernel would get
stuck
in infinite loop creating duplicate sysfs files because, for some
reason,
there are several duplicate boot entries in nvram getting
GetNextVariableName
into a circle of iteration (with period > 2).
Granted, it's not kernel's fault for duplicate variables, but it'd
be much
harder for users to fix their broken firmware than kernel dealing
with it
by not dying on the never-ending GetNextVariableName.
It's not just about the manufacturers fixing their firmware and
distributing a BIOS update. It's also the fact few users are likely
to
apply it before installing Linux on a new machine.
Yeah, we need something in the kernel to handle this.
Unrelated to the initial issue, but with the growing number of fixes
for buggy firmware out there, maybe we should consider an approach
similar to CONFIG_PCI_QUIRKS and the separate drivers/pci/quirks.c,
where all of the system specific EFI quirks are isolated and can be
compiled out if you know your firmware is good?
Also might be nice to have a separate config option specifically for
all the Apple quirks, as their EFI seems to be the worst out there with
respect to following standards.
Thanks for the report guys.
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
