Re: CI/CAM fixes for knc1 dvb-s cards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Christoph Pfister wrote:
> > > <<<fix-knc1-dvbs-ci.diff>>>
> > >        case SUBID_DVBS_KNC1:
> > >        case SUBID_DVBS_KNC1_PLUS:
> > >        case SUBID_DVBS_EASYWATCH_1:
> > >+               budget_av->reinitialise_demod = 1;
> > >
> > > Fix CI interface on (some) KNC1 DVBS cards
> > > Quoting the commit introducing reinitialise_demod (3984 / by adq):
> > > "These cards [KNC1 DVBT and DVBC] need special handling for CI -
> > > reinitialising the frontend device when the CI module is reset."
> > > Apparently my 1894:0010 also needs that fix, because once you initialise
> > > CI/CAM you lose lock. Signed-off-by: Christoph Pfister
> > > <pfister@xxxxxxxxxxx>
> >
> > Are you _sure_ that 'reinitialise_demod = 1' is required by all 3 card
> > types, and does not hurt for SUBID_DVBS_KNC1_PLUS (1131:0011, 1894:0011)
> > and SUBID_DVBS_EASYWATCH_1 (1894:001a)?
> 
> Do you want me to limit reinitialise_demod to the one type of card I'm using 
> or is it ok for you this way?

Yes, please. We should not add a quirk unless we have verified that it
is really required. It is easier to add a hack than to remove it. ;-)

> (I'll repost a modified version of the first patch removing the 0xff check 
> altogether later today ...)

OK. I'll commit your patches this weekend.

-- 
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
----------------------------------------------------------------

_______________________________________________
linux-dvb mailing list
linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

[Index of Archives]     [Linux Media]     [Video 4 Linux]     [Asterisk]     [Samba]     [Xorg]     [Xfree86]     [Linux USB]

  Powered by Linux