2008/3/28, Christoph Pfister <christophpfister@xxxxxxxxx>: <snip> > > Are you _sure_ that 'reinitialise_demod = 1' is required by all 3 card > > types, and does not hurt for SUBID_DVBS_KNC1_PLUS (1131:0011, 1894:0011) > > and SUBID_DVBS_EASYWATCH_1 (1894:001a)? > > > Do you want me to limit reinitialise_demod to the one type of card I'm using > or is it ok for you this way? > > (I'll repost a modified version of the first patch removing the 0xff check > altogether later today ...) <snip> Here it is. Christoph
# HG changeset patch # User Christoph Pfister <pfister@xxxxxxxxxxx> # Date 1206741187 -3600 # Node ID f93c302c14e51dc7dbf2a2625cfc08423c608389 # Parent 0776e480199128519666cc75fa94c4ed64db83f2 Fix support for certain cams in buget-av The current ci implementation doesn't accept 0xff when reading data bytes (address == 0), thus breaks cams which report a buffer size of 0x--ff like my orion one. Remove the 0xff check altogether, because validation is really the job of a higher layer. Signed-off-by: Christoph Pfister <pfister@xxxxxxxxxxx> diff -r 0776e4801991 -r f93c302c14e5 linux/drivers/media/dvb/ttpci/budget-av.c --- a/linux/drivers/media/dvb/ttpci/budget-av.c Fri Mar 28 14:52:44 2008 -0300 +++ b/linux/drivers/media/dvb/ttpci/budget-av.c Fri Mar 28 22:53:07 2008 +0100 @@ -178,7 +178,7 @@ static int ciintf_read_cam_control(struc udelay(1); result = ttpci_budget_debiread(&budget_av->budget, DEBICICAM, address & 3, 1, 0, 0); - if ((result == -ETIMEDOUT) || ((result == 0xff) && ((address & 3) < 2))) { + if (result == -ETIMEDOUT) { ciintf_slot_shutdown(ca, slot); printk(KERN_INFO "budget-av: cam ejected 3\n"); return -ETIMEDOUT;
_______________________________________________ linux-dvb mailing list linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb