Em Dom, 2007-05-06 às 20:50 +0200, Luca Olivetti escreveu: > En/na Mauro Carvalho Chehab ha escrit: > > Hi Luca, > > > > Em Dom, 2007-05-06 às 17:18 +0200, Luca Olivetti escreveu: > >> En/na Luca Olivetti ha escrit: > >>> En/na Luca Olivetti ha escrit: > >>> > >>> > Ok, done. I also added a dependency on qt1010 in Kconfig (forgot to do > >>>> it when I added qt1010 support) and corrected the experimental gain > >>>> reduction of the mt2060 in case of strong signal (though it is code > >>>> included in #ifdef 0) - a patch that I send on the mailing list. > >>>> Due to the size I compressed the patch, I hope it is ok. > >>> And I forgot to exclude dvb-usb-ids.h.orig, so it was in the patch, > >>> please remove it or tell me if I shuld re-send the patch without it. > >> No feedback on this or the patch? > > > > I intend to give you some feedback as soon as possible, maybe later > > today. I'm busy with some stuff here right now. > > > > One trouble I've already noticed is that some hexa values are on > > uppercase. It is weird that indent haven't converted those to lowercase. > > I was supposing that it would solve. > > I just looked at the info page of indent and I cannot see no option that > would convert hex values to lowercase, certainly none of the options in > Lindent does. I suppose I could "fix" it with a simple script, however > I cannot find the section in CodingStyle that says that hexadecimal > values must be lowercase. I'll try later to seek where this is written. I wouldn't pull your patches just due to that. This kind of small adjustments can be done later, anyway. > > Bye -- Cheers, Mauro _______________________________________________ linux-dvb mailing list linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
