Nico Sabbi wrote:
I disagree with your changes:
according to the specs that you linked the fields are:
*switch-number
*switch option
*satellite position
*polarization
*frequency_is_in_hi_band
*bytecode
1 A A V Lo F0
2 A A V Hi F1
3 A A H Lo F2
4 A A H Hi F3
5 A B V Lo F4
6 A B V Hi F5
7 A B H Lo F6
8 A B H Hi F7
9 B A V Lo F8
10 B A V Hi F9
11 B A H Lo FA
12 B A H Hi FB
13 B B V Lo FC
14 B B V Hi FD
15 B B H Lo FE
16 B B H Hi FF
assuming that in the code "pol" stands for "pol_is_vertical" and that
"hi_lo" stands for "hi_band" ( frequency above SLOF) and counting bits
from 8..1
- the last bit must be set to 1 when hi_band is 1
- the forelast bit (0x2) must be set when the polarization is horizontal
(this polv is 0).
Please, explain why you believe that the current code is incorrect
but, on the other side, the high nibble was set incorrectly due to an
off-by-1 bug. Please, test dvbtune and dvbstream from cvs
_______________________________________________
linux-dvb mailing list
linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
