Wilson Michaels wrote:
On Wednesday 31 May 2006 16:49, Harry Coin wrote:
Wilson\:
I'm reading the May 14th version of lgdt330x.c, changeset
4028. In the SNR read routine for the 3303, notice
after line 686 that for VSB tuning the snr decoding logic
picks apart the static buf u8 array -- but that appears
never to have been loaded from the chip first.
Thanks
Harry Coin
Thanks Harry,
There is a line of code missing in lgdt330x.c. Attached is a
diff showing what is required.
Mike,
I don't have the developmental CVS stuff loaded on my system
anymore. I made the attached patch with emacs so is it
probably not the right format.
It only addresses the omission discovered by Harry.
Attached patch signed-off by wmichaels@xxxxxxxxxxxxx
-- Mac
Mac-
Okay, I can apply this for you later on tonight while I push in my other
changesets for the new DViCO cards.
Thanks.
Regards,
Mike Krufky
------------------------------------------------------------------------
diff -c linux-2.6.16-gentoo-r9/drivers/media/dvb/frontends/lgdt330x.c~ linux-2.6.16-gentoo-r9/drivers/media/dvb/frontends/lgdt330x.c
*** linux-2.6.16-gentoo-r9/drivers/media/dvb/frontends/lgdt330x.c~ Mon Jun 19 15:13:06 2006
--- linux-2.6.16-gentoo-r9/drivers/media/dvb/frontends/lgdt330x.c Mon Jun 19 15:13:06 2006
***************
*** 673,678 ****
--- 673,679 ----
if (state->current_modulation == VSB_8) {
/* Phase Tracker Mean-Square Error Register for VSB */
+ i2c_read_demod_bytes(state, 0x6e, buf, 5);
noise = ((buf[0] & 7) << 16) | (buf[3] << 8) | buf[4];
} else {
--
Michael Krufky
_______________________________________________
linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
