On Thursday 20 April 2006 12:37, Oliver Endriss wrote: > Andrew de Quincey wrote: > > Any more comments on this? If not, I'll do a bit more testing and then > > get it applied to head. > > There is a bug in av7110.c (multiple occurrences): > | av7110->fe = ves1820_attach(&philips_cd1516_config, > | &av7110->i2c_adap, read_pwm(av7110)); > | av7110->fe->ops->tuner_ops.set_params = philips_cd1516_tuner_set_params; > > This will cause an OOPS if frontend detection fails (av7110->fe == NULL). Well spotted, thanks. > The same problem might occur if av7110->fe->ops == NULL. I'm not sure > whether the latter can ever happen. That cannot happen no. Well it could.. but it would be a bug in dvb-core, no need to worry about it there. > Btw, should I delay the BSRU2 refactoring [1] until you have committed > your patch? Probably yeah - its quite a big change, and I intend to get it merged tonight. _______________________________________________ linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
