Re: stage 1 of tuner/pll refactoring

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andrew de Quincey wrote:
> Any more comments on this? If not, I'll do a bit more testing and then get it 
> applied to head.

There is a bug in av7110.c (multiple occurrences):
|	av7110->fe = ves1820_attach(&philips_cd1516_config,
|							&av7110->i2c_adap, read_pwm(av7110)); 
|	av7110->fe->ops->tuner_ops.set_params = philips_cd1516_tuner_set_params;

This will cause an OOPS if frontend detection fails (av7110->fe == NULL).
The same problem might occur if av7110->fe->ops == NULL. I'm not sure
whether the latter can ever happen.

Btw, should I delay the BSRU2 refactoring [1] until you have committed
your patch?

CU
Oliver

[1] see '[PATCH] Moving ALPS BSRV2 tuner handling code to separate file'

-- 
--------------------------------------------------------
VDR Remote Plugin available at
http://www.escape-edv.de/endriss/vdr/
--------------------------------------------------------

_______________________________________________

linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

[Index of Archives]     [Linux Media]     [Video 4 Linux]     [Asterisk]     [Samba]     [Xorg]     [Xfree86]     [Linux USB]

  Powered by Linux