Re: [PATCH 4/4] budget-ci: kzalloc conversion, be slightly more verbose about IR init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 22, 2006, Darren Salt wrote:
> Convert to kzalloc.
...
> @@ -1032,7 +1036,7 @@
>  	struct budget_ci *budget_ci;
>  	int err;
>  
> -	if (!(budget_ci = kmalloc(sizeof(struct budget_ci), GFP_KERNEL)))
> +	if (!(budget_ci = kzalloc(sizeof(struct budget_ci), GFP_KERNEL)))
>  		return -ENOMEM;
>  
>  	dprintk(2, "budget_ci: %p\n", budget_ci);

This looks a bit suspicous. Whas the zeroing of *budget_ci
missing before or is it unnecessary?

Anyway, it's not a bad thing to do.


Johannes

_______________________________________________

linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

[Index of Archives]     [Linux Media]     [Video 4 Linux]     [Asterisk]     [Samba]     [Xorg]     [Xfree86]     [Linux USB]

  Powered by Linux