Mac Michaels wrote: >On Tuesday 23 August 2005 12:08 am, Michael Krufky wrote: > > >>DVB: registering new adapter (bttv0). >>DVB: registering frontend 0 (LG Electronics LGDT3303 >>VSB/QAM Frontend)... >> >>...and that last line makes me wonder how come cx88-dvb >>wasn't designed to behave the same way. cx88-dvb prints >>card name instead of frontend name. >> >> >I used a poor template for my driver. I'll look into fixing it. > > Nah, This isn't your fault... This was in the design of cx88-dvb. Here is a patch, but first: This is dmesg BEFORE applying the patch: DVB: registering new adapter (cx88[0]). DVB: registering frontend 0 (DViCO FusionHDTV 3 Gold-T)... ...and this is AFTER applying my patch: DVB: registering new adapter (cx88[0]). DVB: registering frontend 0 (LG Electronics LGDT3302 VSB/QAM Frontend)... I will commit this to video4linux cvs in a few minutes... First, I want to investigate to see if this was done this way for a reason.... Most likely, it was someone's oversight. -- Michael Krufky -------------- next part -------------- Index: cx88-dvb.c =================================================================== RCS file: /cvs/video4linux/video4linux/cx88-dvb.c,v retrieving revision 1.61 diff -u -p -r1.61 cx88-dvb.c --- cx88-dvb.c 19 Aug 2005 15:55:16 -0000 1.61 +++ cx88-dvb.c 25 Aug 2005 05:30:03 -0000 @@ -412,11 +412,6 @@ static int dvb_register(struct cx8802_de dev->dvb.frontend->ops->info.frequency_max = dev->core->pll_desc->max; } - /* Copy the board name into the DVB structure */ - strlcpy(dev->dvb.frontend->ops->info.name, - cx88_boards[dev->core->board].name, - sizeof(dev->dvb.frontend->ops->info.name)); - /* register everything */ return videobuf_dvb_register(&dev->dvb, THIS_MODULE, dev); }
