On Mon, Jun 05, 2017 at 04:07:29PM -0400, David Kershner wrote: > This patchset moves drivers/staging/unisys/include to > include/linux/visorbus, and moves drivers/staging/unisys/visorbus to > drivers/virt/visorbus. Um, are you thinking it is ready to be moved? Have you asked for another review? In a totally random chance, I was doing some driver core work today and I noticed that in drivers/staging/unisys/visorbus/visorbus_main.c, you have 2 tabs for your 'struct attribute' variables, which is really odd. Also, you should be using the ATTRIBUTE_GROUPS() macro for them instead of having to "open code" the struct attribute_group lists. So either you all have horrible luck in that I just happened to find the only remaining problem, or that you should proabably ask for a good code audit, I haven't looked at the code before today since the last round of "fun" I found in just one other random file :) thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
