On Tue, Jun 06, 2017 at 04:49:09PM +0200, Greg KH wrote: > On Mon, Jun 05, 2017 at 04:07:29PM -0400, David Kershner wrote: > > This patchset moves drivers/staging/unisys/include to > > include/linux/visorbus, and moves drivers/staging/unisys/visorbus to > > drivers/virt/visorbus. > > Um, are you thinking it is ready to be moved? Have you asked for > another review? > > In a totally random chance, I was doing some driver core work today and > I noticed that in drivers/staging/unisys/visorbus/visorbus_main.c, you > have 2 tabs for your 'struct attribute' variables, which is really odd. That's the least of the problems. Just about any function in there is doing functionally stupid things. E.g. raw sg_phys() calls for I/O instead of dma mapping routines or parsing SCSI INQUIRY data in the driver. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
