On Wed, Apr 12, 2017 at 09:56:51AM +1000, Tobin C. Harding wrote: > When declaring a function with a function pointer as parameter, having > the parameters to the function pointer prototype with explicit > identifiers does not add that much extra meaning to the code. In this > case the identifiers are 'arg1' and 'arg2', these definitely do not > add extra meaning to the code. Removing them makes the code easier to > read. No, put the arguments in there. If they aren't used, then perhaps the whole function pointer needs to be changed instead? void * use in a driver is usually a sign that something is wrong and can be fixed up. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
