The purpose of this patch set is to improve the readability of the SDIO code within the driver. There are no changes to functionality introduced by this series. The ks7010 driver currently implements the WEXT interface. Currently, wi-fi kernel drivers are expected to use the CFG80211 interface. This series is a step towards that conversion. It will be easier to do the conversion if first the code is nice and clean, and highly readable. Patch 01 replaces preprocessor defines with enumeration types. Patch 02 removes an initialized but unused completion. Patch 03 removes an allocated but unused buffer. Patch 04 removes an unused structure description. Patch 05 removes an initialized but unused spin lock. Patch 06 removes identifiers from function pointer parameter prototype. Patch 07 cleans up header file comments, removes unneeded comments, adds structure kernel doc format comments. Patch 08 renames work_struct structure 'ks_wlan_wakeup_task' to 'wakeup_work'. Patch 09 moves tasklet_struct pointer into device private data structure. Patch 10 moves SDIO related members from hw_info_t structure into device private data structure. Patch 11 adds kernel doc format struct comments to structure used as SDIO func private data. Patch 12 cleans up the SDIO source code comments, removes unneeded comments and fixes typos within the comments. Patch 13 renames a goto label, removing the err_ prefix. Patch 14 fixes checkpatch space before tab warning. Patch 15 fixes checkpatch warning caused by multiple new lines. Patch 16 splits SDIO IO helper functions into two parts, simplifying the common case. Updates all call sites, including debug print statements. Patch 17 fixes checkpatch split string warning caused by debug print statement. Patch 18 renames 'ks7010_sdio.c' to 'sdio.c' and 'ks7010_sdio.h' to 'sdio.h'. Patch is the result of running the following two commands. $ git mv ks7010_sdio.c sdio.c $ git mv ks7010_sdio.h sdio.h Code is untested. Builds on x86_64 and PowerPC. Tobin C. Harding (18): staging: ks7010: replace defines with enums staging: ks7010: remove unused completion staging: ks7010: remove unused read_buf staging: ks7010: remove unused structure description staging: ks7010: remove unused spin_lock staging: ks7010: remove argument identifiers staging: ks7010: clean up SDIO header comments staging: ks7010: rename wakeup work struct staging: ks7010: move tasklet_struct to ks_wlan_private staging: ks7010: move hw info into dev private data staging: ks7010: add struct comment to ks_sdio_card staging: ks7010: clean up SDIO source comments staging: ks7010: remove err_ from non-error path label staging: ks7010: fix checkpatch SPACE_BEFORE_TAB staging: ks7010: fix checkpatch LINE_SPACING staging: ks7010: refactor SDIO read/write helpers staging: ks7010: fix checkpatch SPLIT_STRING staging: ks7010: rename SDIO files drivers/staging/ks7010/Makefile | 2 +- drivers/staging/ks7010/ks7010_sdio.c | 1152 ---------------------------------- drivers/staging/ks7010/ks7010_sdio.h | 148 ----- drivers/staging/ks7010/ks_hostif.c | 20 +- drivers/staging/ks7010/ks_hostif.h | 2 +- drivers/staging/ks7010/ks_wlan.h | 10 +- drivers/staging/ks7010/sdio.c | 1078 +++++++++++++++++++++++++++++++ drivers/staging/ks7010/sdio.h | 176 ++++++ 8 files changed, 1272 insertions(+), 1316 deletions(-) delete mode 100644 drivers/staging/ks7010/ks7010_sdio.c delete mode 100644 drivers/staging/ks7010/ks7010_sdio.h create mode 100644 drivers/staging/ks7010/sdio.c create mode 100644 drivers/staging/ks7010/sdio.h -- 2.7.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
