When declaring a function with a function pointer as parameter, having the parameters to the function pointer prototype with explicit identifiers does not add that much extra meaning to the code. In this case the identifiers are 'arg1' and 'arg2', these definitely do not add extra meaning to the code. Removing them makes the code easier to read. Remove unnecessary identifiers from function parameters of function prototype passed as a parameter. Signed-off-by: Tobin C. Harding <me@xxxxxxxx> --- drivers/staging/ks7010/ks7010_sdio.c | 4 ++-- drivers/staging/ks7010/ks7010_sdio.h | 2 +- drivers/staging/ks7010/ks_hostif.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index 59451f8..f30b8b9 100644 --- a/drivers/staging/ks7010/ks7010_sdio.c +++ b/drivers/staging/ks7010/ks7010_sdio.c @@ -237,7 +237,7 @@ int ks_wlan_hw_power_save(struct ks_wlan_private *priv) static int enqueue_txdev(struct ks_wlan_private *priv, unsigned char *p, unsigned long size, - void (*complete_handler)(void *arg1, void *arg2), + void (*complete_handler)(void *, void *), void *arg1, void *arg2) { struct tx_device_buffer *sp; @@ -337,7 +337,7 @@ static void tx_device_task(struct ks_wlan_private *priv) } int ks_wlan_hw_tx(struct ks_wlan_private *priv, void *p, unsigned long size, - void (*complete_handler)(void *arg1, void *arg2), + void (*complete_handler)(void *, void *), void *arg1, void *arg2) { int result = 0; diff --git a/drivers/staging/ks7010/ks7010_sdio.h b/drivers/staging/ks7010/ks7010_sdio.h index e18ce2b..b9d5a41 100644 --- a/drivers/staging/ks7010/ks7010_sdio.h +++ b/drivers/staging/ks7010/ks7010_sdio.h @@ -114,7 +114,7 @@ struct ks_sdio_card { struct tx_device_buffer { unsigned char *sendp; /* pointer of send req data */ unsigned int size; - void (*complete_handler)(void *arg1, void *arg2); + void (*complete_handler)(void *, void *); void *arg1; void *arg2; }; diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h index aa11d43..f4402ab 100644 --- a/drivers/staging/ks7010/ks_hostif.h +++ b/drivers/staging/ks7010/ks_hostif.h @@ -656,7 +656,7 @@ void hostif_sme_enqueue(struct ks_wlan_private *priv, uint16_t event); int hostif_init(struct ks_wlan_private *priv); void hostif_exit(struct ks_wlan_private *priv); int ks_wlan_hw_tx(struct ks_wlan_private *priv, void *p, unsigned long size, - void (*complete_handler)(void *arg1, void *arg2), + void (*complete_handler)(void *, void *), void *arg1, void *arg2); void send_packet_complete(void *arg1, void *arg2); -- 2.7.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel