Re: [PATCH 6/9] staging: ks7010: Refactor code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 20, 2017 at 03:23:31PM +1100, Tobin C. Harding wrote:
> Code may be refactored to take advantage of previous commit.
> 
> Refactor code. Introduce four new line over 80 warnings. Make code
> more legible.
> 
> Signed-off-by: Tobin C. Harding <me@xxxxxxxx>
> ---
>  drivers/staging/ks7010/ks7010_sdio.c | 31 +++++++++----------------------
>  1 file changed, 9 insertions(+), 22 deletions(-)

You have at least two different commits in this patch series with the
same identical subject line :(

Please fix them all up and make them unique, and a bit more explicit as
to what is going on.  "Refactor code" is not good...

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux