Re: staging: ks7010: Checkpatch fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 20, 2017 at 04:45:05PM +1100, Tobin C. Harding wrote:
> Checkpatch emits various messages. Struct ks_stdio_card contains a
> spinlock. It is never used. The data structure contains two fields,
> both of which are accessed in ways that don't seem to allow use of a
> spinlock. I am not fully qualified however to analyse this.
> 
> Spinlock is either not correctly used or is defined and not needed.
> 
> Fix whitespace errors/warnings/checks. Fix macro definition to clear
> checkpatch check and error.
> 
> Kernelnewbie note: I am unsure how to broach issues like this when
> discovered. In a patch cover letter like this or some other way?
> 

None of these applied to my tree at all, perhaps someone else already
did these before you?

sorry,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux