Checkpatch emits numerous warnings and checks. Line over 80 warnings are not touched. Each patch addresses an individual checkpatch warning (or check). Code is refactored over a series of patches in an effort to modularize the changes. When a patch reduces the indentation no other changes are made in the same patch. Decision to bundle refactoring along with checkpatch fixes was made because the motivating force is checkpatch. Refactoring is limited to the functions surrounding checkpatch warnings, if these changes are deemed satisfactory the rest of the file could be refactored in a similar manner, perhaps that should be done in this series also? 9 patches for the series seemed like it was enough. After application of this series 3 types of checkpatch message remain (line over 80, macro argument reuse, and code compiled out with ifdef). Tobin C. Harding (9): staging: ks7010: Fix checkpatch warnings staging: ks7010: Remove dead code staging: ks7010: Fix checkpatch warning staging: ks7010: Fix checkpatch warning staging: ks7010: refactor, change retval to ret staging: ks7010: Refactor code staging: ks7010: Remove level of indentation staging: ks7010: Refactor code staging: ks7010: Fix checkpatch whitespace checks drivers/staging/ks7010/ks7010_sdio.c | 274 ++++++++++++++++------------------- 1 file changed, 123 insertions(+), 151 deletions(-) -- 2.7.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
