[PATCH 1/9] staging: ks7010: Fix checkpatch warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



There are multiple line dereferences. This leaves a '.' as the
last character of the line and makes the code hard to read.

Move variable dereference onto single line. Even if this causes line
over 80 warning.

Signed-off-by: Tobin C. Harding <me@xxxxxxxx>
---
 drivers/staging/ks7010/ks7010_sdio.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index a604c83..129702c 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -223,8 +223,8 @@ static int _ks_wlan_hw_power_save(struct ks_wlan_private *priv)
 						DPRINTK(4,
 							"PMG SET!! : GCR_B=%02X\n",
 							rw_data);
-						atomic_set(&priv->psstatus.
-							   status, PS_SNOOZE);
+						atomic_set(&priv->psstatus.status,
+							PS_SNOOZE);
 						DPRINTK(3,
 							"psstatus.status=PS_SNOOZE\n");
 					} else {
@@ -232,8 +232,7 @@ static int _ks_wlan_hw_power_save(struct ks_wlan_private *priv)
 								   &priv->ks_wlan_hw.rw_wq, 1);
 					}
 				} else {
-					queue_delayed_work(priv->ks_wlan_hw.
-							   ks7010sdio_wq,
+					queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,
 							   &priv->ks_wlan_hw.rw_wq,
 							   0);
 				}
@@ -334,8 +333,7 @@ static void tx_device_task(void *dev)
 			if (rc) {
 				DPRINTK(1, "write_to_device error !!(%d)\n",
 					rc);
-				queue_delayed_work(priv->ks_wlan_hw.
-						   ks7010sdio_wq,
+				queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,
 						   &priv->ks_wlan_hw.rw_wq, 1);
 				return;
 			}
@@ -635,10 +633,8 @@ static void ks_sdio_interrupt(struct sdio_func *func)
 						if (cnt_txqbody(priv)) {
 							ks_wlan_hw_wakeup_request(priv);
 							queue_delayed_work
-							    (priv->ks_wlan_hw.
-							     ks7010sdio_wq,
-							     &priv->ks_wlan_hw.
-							     rw_wq, 1);
+							    (priv->ks_wlan_hw.ks7010sdio_wq,
+ 							     &priv->ks_wlan_hw.rw_wq, 1);
 							return;
 						}
 					} else {
-- 
2.7.4

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux