Re: [PATCH] staging: sm750fb: Fix lock context error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 23, 2016 at 03:37:57PM +0300, Alex Briskin wrote:
> Sparse error fix - different lock contexts for basic block.
> Acquirement and release of spin lock was dependent on two separate
> unprotected variable evaluations. Instead the condition evaluation result
> is stored in a local boolean variable to make sure that the same context
> that called the spin_lock will evoke spin_unlock.
> 

I kind of feel like this doesn't improve readability.

Sparse kind of sucks at flow analysis so I feel like working around
Sparse limitations is a waste of time.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux