Fix the subject. Add a changelog. Add a signed-off-by. Break the patch into three patches where each patch cleans up a specific type of coding style warning. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel