On Monday, 24 October 2016 13:41:39 IDT Dan Carpenter wrote: > evaluation Hi Dan, Thanks you for your feedback, it kind of felt like workaround. However, it seems to me like bad design decision took place where locking/ unlocking is dependent on unprotected variable. >From what I could understand from the driver source code the fb_count value shouldn't change while in those functions, so the code is safe "as is" and my change should only assist with readability. So the patch fails to improve readability it is unnecessary. Best regards, Alex _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
