On Mon, 2016-10-03 at 20:12 +0200, Sergio Paracuellos wrote: > El 2016年10月03日 a las 18:16, Joe Perches escribió: > > Perhaps better as hw->scanresults = kmemdup(inf, sizeof(*inf), GFP_ATOMIC); > I agree. But because all the code is full of sizeof(struct xxx) I though > it would be bettter to follow the actual style and not change only one... > I don't have any problem in fix this patch and resend it. What should I do? I suggest not fixing this patch. Maybe just send another patch changing all the applicable sizeof(struct <foo>) uses to sizeof(*var) with the appropriate line wrapping. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel