Re: [PATCH] staging: greybus: fix block comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 03, 2016 at 11:45:15PM +0900, Hisao Tanabe wrote:
> This patch fix the coding style problem of block comment detected by the
> checkpatch.pl.
> 
> WARNING: Block comments use a trailing */ on a separate line
> 
> Signed-off-by: Hisao Tanabe <xtanabe@xxxxxxxxx>
> ---
>  drivers/staging/greybus/arche-apb-ctrl.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/greybus/arche-apb-ctrl.c
> index 70323aa..3fda0cd 100644
> --- a/drivers/staging/greybus/arche-apb-ctrl.c
> +++ b/drivers/staging/greybus/arche-apb-ctrl.c
> @@ -183,7 +183,7 @@ static int standby_boot_seq(struct platform_device *pdev)
>  	 * Pasted from WDM spec,
>  	 *  - A falling edge on POWEROFF_L is detected (a)
>  	 *  - WDM enters standby mode, but no output signals are changed
> -	 * */
> +	 */
>  
>  	/* TODO: POWEROFF_L is input to WDM module  */
>  	apb->state = ARCHE_PLATFORM_STATE_STANDBY;
> @@ -285,8 +285,10 @@ static ssize_t state_store(struct device *dev,
>  		if (apb->state == ARCHE_PLATFORM_STATE_FW_FLASHING)
>  			return count;
>  
> -		/* First we want to make sure we power off everything
> -		 * and then enter FW flashing state */
> +		/*
> +		 * First we want to make sure we power off everything
> +		 * and then enter FW flashing state
> +		 */
>  		poweroff_seq(pdev);
>  		ret = fw_flashing_seq(pdev);
>  	} else {

Patch looks fine, but note that someone just sent a patch for this
second chunk the other day.

Acked-by: Johan Hovold <johan@xxxxxxxxxx>

Johan
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux