Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in prism2sta.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



El 2016年10月03日 a las 20:18, Joe Perches escribió:
On Mon, 2016-10-03 at 20:12 +0200, Sergio Paracuellos wrote:
El 2016年10月03日 a las 18:16, Joe Perches escribió:
Perhaps better as	hw->scanresults = kmemdup(inf, sizeof(*inf), GFP_ATOMIC);
I agree. But because all the code is full of sizeof(struct xxx) I though
it would be bettter to follow the actual style and not change only one...
I don't have any problem in fix this patch and resend it. What should I do?

I suggest not fixing this patch.

Maybe just send another patch changing all the applicable
sizeof(struct <foo>) uses to sizeof(*var) with the appropriate
line wrapping.


Ok, I think that it would be better too. Let's do that.

Thanks,
	Sergio Paracuellos
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux