On Fri, 2016-08-19 at 20:44 +0100, James Simmons wrote: > > 1: I'd like to see the lustre #include files separated into > > only two internal/external directories akin to the > > include/linux and include/uapi directories used by linux. [] > For the first question yes it is reasonable and developers > have been working to cleanup and separate out the uapi headers > from the normal kernel headers. For staging/lustre/lustre we > have local headers *_internal.h which only matter for that > particular subdirectory. The rest of the headers are all in > > staging/lustre/lustre/include/* > > In that directory we have the linux subdirectory. That has > gone away in newer lustre versions so I would need to push > the patch to remove it. The other directory > > staging/lustre/lustre/include/lustre/* > > contains all our uapi headers like lustre_user.h and lustre_idl.h. > Well that is not entirely correct. We still have uapi headers > like uapi_kernelcomm.h one directory up. It just if we change those > I need to update our userland tools as well. I have a patch ready > but I need to push it to our utility branch as well. > The next lot is all the LNet/libcfs stuff. The good news for LNet > the headers have been cleaned up so separating them out is easy. > Well there can always be more improvements. Now libcfs is a bit > messy. The libcfs/linux directory needs to be removed yet. Also > libcfs_debug.h needs to broken up for uapi use. > > Thats the run down about where we are at for the headers. Also it > gives you an idea where we are heading. So how do you need this > layed out for what you want to do? Where do you want to place the > headers? Thanks. I don't _need_ anything, but I think it'd be simpler to have just 2 directories, one for lustre kernel stuff and another for lustre uapi stuff. That applies for LNet and libcfs #includes as well. To me, ideally, there'd only be 2 #include directories so that the only used #include styles could become: #include <linux/lustre/foo.h> and #include <uapi/lustre/bar.h> and that would work regardless of lustre's layout in staging or elsewhere. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
