On Mon, Mar 21, 2016 at 03:08:41PM +0530, PrasannaKumar Muralidharan wrote: > > Are you sure you can just remove these markings? Does the code work the > > same? What is properly locking these values? Why were they marked this > > way in the first place? > > I could not test the change due to lack of hardware. > > Given that the code works without lock and as volatile does not > guarantee any sort of locking I understand that lock is not necessary. > Please correct me if I am wrong. > > Could not find the purpose of 'volatile' in the code, > 'request_counter' and 'service_counter' are only accessed by the CPU. > So I think it can be removed. I will need the maintainers of the code to ack this before I can accept it... _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
