On Sat, Mar 12, 2016 at 02:11:10PM +0530, PrasannaKumar Muralidharan wrote:
> From: PrasannaKumar Muralidharan <prasannatsmkumar@xxxxxxxxx>
>
> Remove unnecessary use of volatile for 'request_counter' and
> 'service_counter' members.
>
> Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@xxxxxxxxx>
> ---
> drivers/staging/most/hdm-dim2/dim2_hal.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/most/hdm-dim2/dim2_hal.h b/drivers/staging/most/hdm-dim2/dim2_hal.h
> index 1c924e8..ee10ed9 100644
> --- a/drivers/staging/most/hdm-dim2/dim2_hal.h
> +++ b/drivers/staging/most/hdm-dim2/dim2_hal.h
> @@ -40,10 +40,10 @@ struct dim_ch_state_t {
>
> struct int_ch_state {
> /* changed only in interrupt context */
> - volatile int request_counter;
> + int request_counter;
Are you sure you can just remove these markings? Does the code work the
same? What is properly locking these values? Why were they marked this
way in the first place?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
