Re: [PATCH] Staging: most: Remove volatile usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Are you sure you can just remove these markings?  Does the code work the
> same?  What is properly locking these values?  Why were they marked this
> way in the first place?

I could not test the change due to lack of hardware.

Given that the code works without lock and as volatile does not
guarantee any sort of locking I understand that lock is not necessary.
Please correct me if I am wrong.

Could not find the purpose of 'volatile' in the code,
'request_counter' and 'service_counter' are only accessed by the CPU.
So I think it can be removed.

Thanks,
PrasannaKumar
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux