[PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver

[Bijosh Thykkoottathil <bijosh.t@xxxxxxxxxxx>]

Fixes following coding style issues reported by the check patch script.
    - ERROR: Macros with complex values should be enclosed in parentheses

    Moving static storage class to the beginning of declaration fixes these
    errors.

Signed-off-by: Bijosh Thykkoottathil <bijosh.t@xxxxxxxxxxx>
---
 drivers/staging/most/mostcore/core.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c
index ed1ed25..a4e5013 100644
--- a/drivers/staging/most/mostcore/core.c
+++ b/drivers/staging/most/mostcore/core.c
@@ -121,7 +121,7 @@ struct most_c_attr {
 #define to_channel_attr(a) container_of(a, struct most_c_attr, attr)
 
 #define MOST_CHNL_ATTR(_name, _mode, _show, _store) \
-		struct most_c_attr most_chnl_attr_##_name = \
+		static struct most_c_attr most_chnl_attr_##_name = \
 		__ATTR(_name, _mode, _show, _store)
 
 /**
@@ -335,7 +335,7 @@ static ssize_t show_channel_starving(struct most_c_obj *c,
 }
 
 #define create_show_channel_attribute(val) \
-	static MOST_CHNL_ATTR(val, S_IRUGO, show_##val, NULL)
+		MOST_CHNL_ATTR(val, S_IRUGO, show_##val, NULL)
 
 create_show_channel_attribute(available_directions);
 create_show_channel_attribute(available_datatypes);
@@ -484,7 +484,7 @@ static ssize_t store_set_packets_per_xact(struct most_c_obj *c,
 }
 
 #define create_channel_attribute(value) \
-	static MOST_CHNL_ATTR(value, S_IRUGO | S_IWUSR, \
+		MOST_CHNL_ATTR(value, S_IRUGO | S_IWUSR, \
 			      show_##value, \
 			      store_##value)
 
@@ -578,7 +578,7 @@ static void destroy_most_c_obj(struct most_c_obj *c)
  *		     ___I N S T A N C E___
  */
 #define MOST_INST_ATTR(_name, _mode, _show, _store) \
-		struct most_inst_attribute most_inst_attr_##_name = \
+		static struct most_inst_attribute most_inst_attr_##_name = \
 		__ATTR(_name, _mode, _show, _store)
 
 static struct list_head instance_list;
@@ -703,7 +703,7 @@ static ssize_t show_interface(struct most_inst_obj *instance_obj,
 }
 
 #define create_inst_attribute(value) \
-	static MOST_INST_ATTR(value, S_IRUGO, show_##value, NULL)
+		MOST_INST_ATTR(value, S_IRUGO, show_##value, NULL)
 
 create_inst_attribute(description);
 create_inst_attribute(interface);
-- 
2.5.0

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel