Thanks for your comments. Will create separate patches for each changes. Regards, -Bijosh. On Fri, Jan 29, 2016 at 11:02:27PM +0530, Sudip Mukherjee wrote: > On Fri, Jan 29, 2016 at 10:38:42PM +0530, Bijosh Thykkoottathil wrote: > > From: Bijosh Thykkoottathil <bijosh.t@xxxxxxxxxxx> > > You do not need this From: line here. The email From: header is > sufficient. > > > > > Fixes following coading style issues reported by the check patch script. > > - ERROR: Macros with complex values should be enclosed in parentheses > > - CHECK: struct mutex definition without comment > > - CHECK: spinlock_t definition without comment > > - CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code > > rather than BUG() or BUG_ON() > > - WARNING: storage class should be at the beginning of the declaration > > You are doing too many things in one patch. Please break them up into > separate patches. Each patch should do only one type of change. > > regards > sudip _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
